Revision 17fafe9...

Go back to digest for 9th September 2012

Bug Fixes in Office

Dmitry Kazakov committed changes in [calligra/calligra/2.5] /:

Fixed Zoom/Pan with vastScrolling disabled

This patch finishes the set of patches which fixed bugs in zoom/pan and
added tests for it. This patch introduces the following:

1) We don't use documentOrigin() anymore. At all. The centering is done
directly inside the transformation inside the KisCoordinatesConverter.
2) Fixed bug when KisCanvasController used setScrollBarValue() for
correcting the offset, which caused poisoning of
preferredCenterFractionX/Y. This was quite subtle bug.
3) Added tests for rotation of the canvas with and without vast scrolling

File Changes

Modified 18 files
  •   krita/ui/kis_view2.cpp
  •   krita/ui/kis_zoom_manager.cc
  •   libs/flake/KoCanvasControllerWidget.cpp
  •   libs/flake/KoCanvasControllerWidget.h
  •   krita/ui/canvas/kis_canvas2.cpp
  •   krita/ui/canvas/kis_canvas2.h
  •   krita/ui/canvas/kis_canvas_controller.cpp
  •   krita/ui/canvas/kis_canvas_widget_base.cpp
  •   krita/ui/canvas/kis_coordinates_converter.cpp
  •   krita/ui/canvas/kis_coordinates_converter.h
  •   krita/ui/canvas/kis_qpainter_canvas.cpp
  •   krita/ui/canvas/kis_qpainter_canvas.h
  •   krita/ui/opengl/kis_opengl_canvas2.cpp
  •   krita/ui/opengl/kis_opengl_canvas2.h
  •   krita/ui/tests/kis_coordinates_converter_test.cpp
  •   krita/ui/tests/kis_prescaled_projection_test.cpp
  •   krita/ui/tests/kis_zoom_and_pan_test.cpp
  •   krita/ui/tests/kis_zoom_and_pan_test.h
18 files changed in total